From dad35616f63ff774a5831cbbd5f220d70ec21e87 Mon Sep 17 00:00:00 2001 From: HoshizukiMio Date: Tue, 17 Nov 2026 19:14:04 +0800 Subject: [PATCH] Close Windows smoke-test terminals gracefully --- tests/smoke.py | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/smoke.py b/tests/smoke.py index f57fafe9..c6a3f9a0 100644 --- a/tests/smoke.py +++ b/tests/smoke.py @@ -178,7 +178,18 @@ def terminal(binary, root, env): try: yield lambda: process.read(16384), process.isalive finally: - process.close(force=True) + if process.isalive(): + with contextlib.suppress(EOFError): + process.write("/exit\r") + deadline = time.monotonic() + 5 + while process.isalive() and time.monotonic() < deadline: + time.sleep(0.05) + try: + process.close(force=True) + except PermissionError: + # ConPTY can exit between pywinpty's process check and its termination call. + if process.isalive(): + raise else: import fcntl import pty